Implement bodysummary without private APIs#1147
Merged
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1147 +/- ##
==========================================
- Coverage 82.67% 82.46% -0.22%
==========================================
Files 32 32
Lines 3054 3062 +8
==========================================
Hits 2525 2525
- Misses 529 537 +8 ☔ View full report in Codecov by Sentry. |
vtjnash
force-pushed
the
jn/bodysummary-IOB
branch
from
0bb15a9 to
92ef510
Compare
vtjnash
force-pushed
the
jn/bodysummary-IOB
branch
from
92ef510 to
364f4b3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am sort of uncertain why this bodysummary is everything in the file before the content that is being sent. Shouldn't the
seekstart(data)be deleted here and read to the end instead of to stopping at positionm?